#935 Logically dead code in pyhbac.c
Closed: Fixed None Opened 12 years ago by sgallagh.

From Coverity scan:

 250        if (s) {
 251            s = py_strcat_realloc(s, delim);
 252            if (s == NULL) goto fail;
 253            s = py_strcat_realloc(s, part);
CID 10891: Logically dead code (DEADCODE)After this line (or expression), the value of "s" cannot be 0.
 254            if (s == NULL) goto fail;
 255        } else {
 256            s = py_strdup(part);
After this line (or expression), the value of "s" cannot be 0.
 257            if (s == NULL) goto fail;
 258        }
 259        Py_DECREF(item);
On this path, the condition "s == NULL" cannot be true.
 260        if (s == NULL) {
Execution cannot reach this statement "PyErr_NoMemory();".
 261            PyErr_NoMemory();
 262            goto fail;
 263        }
 264    }

Fields changed

patch: 0 => 1

master: 778d3b4

milestone: NEEDS_TRIAGE => SSSD 1.6.0
resolution: => fixed
status: new => closed

Backported to sssd-1-5

d527888

milestone: SSSD 1.6.0 => SSSD 1.5.12

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to jhrozek
- Issue set to the milestone: SSSD 1.5.12

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1977

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata