#741 Dead code in the ini value serialization
Closed: Fixed None Opened 13 years ago by dpal.

In the code the error check after ref_array_get is invalid. Instead len should be set to 0 before the error check shold be removed.

        for (i = 0; i < vln; i++) {
            /* Get line */
            ptr = ref_array_get(vo->raw_lines, i, NULL);

            if (ptr) {
                /* Get its length */
                ref_array_get(vo->raw_lengths, i, (void *)&len);
                if (error) {
                    TRACE_ERROR_NUMBER("Failed to add string", error);
                    return error;
                }

                part = *((char **)(ptr));

Fields changed

keywords: => Coverity

Fields changed

keywords: => Coverity

Fields changed

keywords: => Coverity

Fields changed

rhbz: => 0

Fields changed

rhbz: => 0

Fields changed

rhbz: => 0

This code is already re-factored in the current tree and does not have the described issue. Closing.

blockedby: =>
blocking: =>
feature_milestone: =>
milestone: Tools Backlog => Tools 1.0
patch: => 0
resolution: => fixed
status: new => closed

This code is already re-factored in the current tree and does not have the described issue. Closing.

blockedby: =>
blocking: =>
feature_milestone: =>
milestone: Tools Backlog => Tools 1.0
patch: => 0
resolution: => fixed
status: new => closed

This code is already re-factored in the current tree and does not have the described issue. Closing.

blockedby: =>
blocking: =>
feature_milestone: =>
milestone: Tools Backlog => Tools 1.0
patch: => 0
resolution: => fixed
status: new => closed

Metadata Update from @dpal:
- Issue set to the milestone: Tools 1.0

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1783

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata