#659 hbac_get_host_info_send() constructs its search filter inefficiently
Closed: Fixed None Opened 13 years ago by sgallagh.

We loop through and add the following for every host:

        state->host_filter = talloc_asprintf_append(state->host_filter,
                                             "(&(objectclass=ipaHost)"
                                             "(|(fqdn=%s)(serverhostname=%s)))",
                                             hostnames[i], hostnames[i]);

It would make more sense to move the {{{(&(objectclass=ipaHost)}}} to wrap globally around all of the other search strings, and thus shorten the resulting filter string. If there are many hosts being requested, this construct may end up exceeding the maximum filter string.


Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.5.0
owner: somebody => sbose

Fixed by f778b38

resolution: => fixed
status: new => closed

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to sbose
- Issue set to the milestone: SSSD 1.5.0

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1701

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata