Learn more about these different git repos.
Other Git URLs
In {{{dp_err_to_string()}}} we call strerror(errnum) in several places.
However, universally in the code, we're passing in PAM error codes here, not errno error codes. So these are always printing a confusing debug message.
Ideally, this should be replaced with pam_strerror(), but that function inexplicably requires a pam_handler_t * argument that we don't have available at the time. Perhaps one can be simulated on the fly.
TBH, I think it is time to reserve an error space (see how dhash or krb5 do it) for SSSD and start defining our own error codes. We have stretched whatever error codes the system has available but it would be nice to have something more specific in more than one place.
Replying to [comment:1 simo]:
See https://fedorahosted.org/sssd/ticket/453
This ticket is only about the fact that we have a bug in that we are passing one type into a different type's error_to_string function. That's producing unreliable noise that makes it harder to track down what is really causing an issue.
Fields changed
milestone: NEEDS_TRIAGE => SSSD 1.5.0 owner: somebody => jhrozek
priority: major => trivial
owner: jhrozek => sgallagh
status: new => assigned
Fixed by 4b03093
resolution: => fixed status: assigned => closed
rhbz: => 0
Metadata Update from @sgallagh: - Issue assigned to sgallagh - Issue set to the milestone: SSSD 1.5.0
SSSD is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in SSSD's github repository.
This issue has been cloned to Github and is available here: - https://github.com/SSSD/sssd/issues/1678
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Login to comment on this ticket.