#575 [path_utils] dead storage in path_utils.c
Closed 7 years ago Opened 13 years ago by jhrozek.

Two cases of dead storage in path_utils.c:

- in `directory_list()`, the value of `prune` in unconditionally overwritten after the first assignment:
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-NCECM2.html#EndPath

- in `is_ancestor_path()`, the value of result is set in all the branches which also return as well as when no branch is selected. Maybe it would be nicer to rewrite the code with if..else if..else..
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-gp1oRt.html#EndPath

- in `split_path()`, although the value stored to `component_len` is used in the enclosing expression, the value is never actually read from `component_len` after that point:
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-rpgeQB.html#EndPath

Assigning to dpal as per his request.


Fields changed

priority: major => minor

Fields changed

priority: major => minor

Fields changed

priority: major => minor

Fields changed

milestone: NEEDS_TRIAGE => Tools 1.0

Fields changed

milestone: NEEDS_TRIAGE => Tools 1.0

Fields changed

milestone: NEEDS_TRIAGE => Tools 1.0

Fields changed

rhbz: => 0

Fields changed

rhbz: => 0

Fields changed

rhbz: => 0

Fields changed

blockedby: =>
blocking: =>
coverity: =>
feature_milestone: =>
milestone: Tools Backlog => Tools 2.0
patch: => 0

Fields changed

blockedby: =>
blocking: =>
coverity: =>
feature_milestone: =>
milestone: Tools Backlog => Tools 2.0
patch: => 0

Fields changed

blockedby: =>
blocking: =>
coverity: =>
feature_milestone: =>
milestone: Tools Backlog => Tools 2.0
patch: => 0

Fields changed

design: =>
design_review: => 0
fedora_test_page: =>
selected: =>
testsupdated: 0 => 1

Fields changed

design: =>
design_review: => 0
fedora_test_page: =>
selected: =>
testsupdated: 0 => 1

Fields changed

design: =>
design_review: => 0
fedora_test_page: =>
selected: =>
testsupdated: 0 => 1

Fields changed

patch: 0 => 1
testsupdated: 1 => 0

Fields changed

patch: 0 => 1
testsupdated: 1 => 0

Fields changed

patch: 0 => 1
testsupdated: 1 => 0

Metadata Update from @jhrozek:
- Issue assigned to dpal
- Issue set to the milestone: Tools 2.0

7 years ago

Metadata Update from @lslebodn:
- Custom field component reset
- Custom field design_review reset
- Custom field patch adjusted to on (was: 1)
- Custom field testsupdated reset
- Custom field type reset
- Custom field version reset
- Issue close_status updated to: None

7 years ago

Metadata Update from @lslebodn:
- Custom field design_review reset
- Custom field patch reset
- Custom field testsupdated reset
- Issue status updated to: Closed (was: Open)

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1617

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata