Learn more about these different git repos.
Other Git URLs
The SSSDConfig API should be extended to verify values before they are saved. Right now, we are limited to verifying that the type matches, but this is not very efficient.
The schema for the sssd.api.conf should be expanded to provide a perl-style regular expression that must be matched for the option to be saved. This would allow us to handle complicated conditions, as well as enumerated types.
I'm proposing this for SSSD 1.2.
Fields changed
milestone: NEEDS_TRIAGE => SSSD 1.2
Rather than just regular expressions, it should probably be more generic. Range validation for integral types, enumerations, etc.
milestone: SSSD 1.2 => SSSD 1.3 summary: SSSDConfig API should perform regular-expression matching for values => SSSDConfig API should perform input-validation for values
I'm extending this to encompass a series of bugs against the SSSD itself as well. Right now, we're too accepting of unknown and poorly-formed entries in the sssd.conf in both the SSSDConfig API and the daemon itself.
My proposed approach will be to redesign the sssd.api.conf as an XML document that will contain validation information for the options it contains. The daemon and the SSSDConfig API should both refer to this file (and its drop directory for provider options) in order to validate the config file.
Related Bugzilla Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=578511 https://bugzilla.redhat.com/show_bug.cgi?id=578503 https://bugzilla.redhat.com/show_bug.cgi?id=578498
component: SSSDConfig API => SSSD owner: sgallagh => somebody summary: SSSDConfig API should perform input-validation for values => SSSD should perform input-validation for values in sssd.conf tests: 0 => 1
owner: somebody => sgallagh
milestone: SSSD 1.5.0 => SSSD 1.6.0
coverity: => milestone: SSSD 1.6.0 => SSSD 1.7.0 owner: sgallagh => dpal upgrade: => 0
milestone: SSSD 1.8.0 => SSSD 1.9.0 patch: => 0
blockedby: => blocking: => milestone: SSSD 1.9.0 => SSSD Deferred rhbz: =>
rhbz: => 0
Linked to Bugzilla bug: https://bugzilla.redhat.com/show_bug.cgi?id=578511 (Fedora)
rhbz: 0 => [https://bugzilla.redhat.com/show_bug.cgi?id=578511 578511]
Linked to Bugzilla bug: https://bugzilla.redhat.com/show_bug.cgi?id=1025825 (Red Hat Enterprise Linux 6)
rhbz: [https://bugzilla.redhat.com/show_bug.cgi?id=578511 578511] => [https://bugzilla.redhat.com/show_bug.cgi?id=578511 578511], [https://bugzilla.redhat.com/show_bug.cgi?id=1025825 1025825]
Linked to Bugzilla bug: https://bugzilla.redhat.com/show_bug.cgi?id=1077695 (Red Hat Enterprise Linux 7)
rhbz: [https://bugzilla.redhat.com/show_bug.cgi?id=578511 578511], [https://bugzilla.redhat.com/show_bug.cgi?id=1025825 1025825] => [https://bugzilla.redhat.com/show_bug.cgi?id=578511 578511], [https://bugzilla.redhat.com/show_bug.cgi?id=1025825 1025825], [https://bugzilla.redhat.com/show_bug.cgi?id=1077695 1077695]
Closing as duplicate of #2269
changelog: => design: => design_review: => 0 feature_milestone: => fedora_test_page: => mark: => 0 resolution: => duplicate review: => 0 selected: => status: new => closed
Metadata Update from @sgallagh: - Issue assigned to dpal - Issue marked as depending on: #1621 - Issue marked as depending on: #1622 - Issue set to the milestone: SSSD Patches welcome
SSSD is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in SSSD's github repository.
This issue has been cloned to Github and is available here: - https://github.com/SSSD/sssd/issues/1458
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Login to comment on this ticket.