#2780 Please use POSIX extended regexes instead of basic
Closed 7 years ago Opened 8 years ago by rharwood.

In ini_aug_regex_prepare(), regcomp(7) is called without passing REG_EXTENDED. This results in POSIX Basic regular expressions being used. This is undesirable largely because it is unexpected and unfamiliar to most people who have worked with regular expressions before. Basic REs lack many of the features of the extended set; as per the man page, "'|', '+', and '?' are ordinary characters and there is no equivalent for their functionality.".

All that said, I can understand a case for not wanting extended regexes (if I understand correctly, extended supports backreferences while basic does not). However, either way the decision is made, it does need to be specified in the documentation; having to read the implementation to figure this out is a bit much.


Fields changed

rhbz: => todo

Fields changed

rhbz: => todo

Fields changed

rhbz: => todo

Metadata Update from @rharwood:
- Issue set to the milestone: ding-libs 0.6.0

7 years ago

Metadata Update from @lslebodn:
- Custom field component reset
- Custom field design_review reset
- Custom field mark reset
- Custom field patch reset
- Custom field review reset
- Custom field sensitive reset
- Custom field testsupdated reset
- Custom field type reset
- Custom field version reset
- Issue close_status updated to: None

7 years ago

Metadata Update from @lslebodn:
- Custom field design_review reset
- Custom field mark reset
- Custom field patch reset
- Custom field review reset
- Custom field sensitive reset
- Custom field testsupdated reset
- Issue status updated to: Closed (was: Open)

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/3821

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata