#2679 sssd components mishandles sighup for helper processes
Closed: duplicate 6 years ago Opened 8 years ago by jhrozek.

Ticket was cloned from Red Hat Bugzilla (product Red Hat Enterprise Linux 6): Bug 1232303

Description of problem:
This BZ is related to #886038

sssd doesn't properly close fds from helper processes like krb5_child:

# ls /proc/*/fd -l| grep deleted
l-wx------. 1 root root 64 Jun  3 10:13 18 ->
/var/log/sssd/krb5_child.log-20150512 (deleted)

ssd debug_log_file is opened with open_debug_file_ex(..., bool want_cloexec):

[...]

(want_cloexec) {
         flags = fcntl(debug_fd, F_GETFD, 0);
         (void) fcntl(debug_fd, F_SETFD, flags | FD_CLOEXEC);
     }

(from util/debug.c)

This is not the case for LDAP_CHILD_LOG_FILE and KRB5_CHILD_LOG_FILE:

$ grep -iR CHILD_LOG_FILE providers/
providers/krb5/krb5_init_shared.c:        ret =
open_debug_file_ex(KRB5_CHILD_LOG_FILE, &debug_filep, false);
providers/ldap/sdap_child_helpers.c:        ret =
open_debug_file_ex(LDAP_CHILD_LOG_FILE, &debug_filep, false);


Version-Release number of selected component (if applicable):
sssd-1.11.6-30.el6_6.3.x86_64

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Fields changed

blockedby: =>
blocking: =>
changelog: =>
coverity: =>
design: =>
design_review: => 0
feature_milestone: =>
fedora_test_page: =>
mark: no => 0
owner: somebody => mzidek
review: True => 0
selected: =>
testsupdated: => 0

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.13 beta

Fields changed

priority: major => minor

Fields changed

milestone: SSSD 1.13.1 => SSSD 1.13.2

Fields changed

milestone: SSSD 1.13.2 => SSSD 1.13.3

De-prioritizing to Deferred...

milestone: SSSD 1.13.3 => SSSD Deferred

Metadata Update from @jhrozek:
- Issue assigned to mzidek
- Issue set to the milestone: SSSD Patches welcome

7 years ago

Closing as duplicate of #3647 (because that one has a valid downstream link, so this direction is easier)

Metadata Update from @jhrozek:
- Custom field design_review reset (from 0)
- Custom field mark reset (from 0)
- Custom field patch reset (from 0)
- Custom field review reset (from 0)
- Custom field sensitive reset (from 0)
- Custom field testsupdated reset (from 0)
- Issue close_status updated to: duplicate
- Issue status updated to: Closed (was: Open)

6 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/3720

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata