#2428 contrib/ci/run script: Prepare suppression database for valgrind test
Closed: Fixed None Opened 9 years ago by lslebodn.

On RHLE6 we have old versions of libraries and we have compile time warnings, which cannot he suppressed

src/providers/krb5/krb5_child.c: In function ‘changepw_child’:
src/providers/krb5/krb5_child.c:1122: warning: passing argument 8 of ‘krb5_get_init_creds_password’ discards qualifiers from pointer target type
/usr/include/krb5/krb5.h:6686: note: expected ‘char *’ but argument is of type ‘const char *’
  CC     src/util/krb5_child-sss_krb5.o
src/providers/krb5/krb5_child.c: In function ‘tgt_req_child’:
src/providers/krb5/krb5_child.c:1296: warning: passing argument 8 of ‘krb5_get_init_creds_password’ discards qualifiers from pointer target type
/usr/include/krb5/krb5.h:6686: note: expected ‘char *’ but argument is of type ‘const char *’

and there is also false positive warning from valgrind

==2750== Conditional jump or move depends on uninitialised value(s)
==2750==    at 0x3194536668: ??? (strcpy.S:98)
==2750==    by 0x611E527: sha512_crypt_r (nss_sha512crypt.c:288)
==2750==    by 0x611E7F7: s3crypt_sha512 (nss_sha512crypt.c:345)
==2750==    by 0x4E3CF32: sysdb_cache_auth (sysdb_ops.c:3269)
==2750==    by 0x40943E: cached_authentication_without_expiration (sysdb-tests.c:1742)
==2750==    by 0x4096A2: test_sysdb_cached_authentication_wrong_password (sysdb-tests.c:1853)
==2750==    by 0x4C1F87D: srunner_run_all (in /usr/lib64/libcheck.so.0.0.0)
==2750==    by 0x405728: main (sysdb-tests.c:6103)

This is a reason why we need to be able to ignore failures from some test per platform.


Fields changed

summary: contrib/ci/run script: Add possibility to ignore tests on specific platform => contrib/ci/run script: Add possibility to ignore failed tests per distribution

Fields changed

owner: somebody => nkondras

What is state of this ticket?
If you are working on this ticket please change state to assigned.

Please fix it ASAP, it is blocker because valgrind test is part of essential suite.

You can always just add a condition on DISTRO_BRANCH or on any other DISTRO_* variable from distro.sh to contrib/ci/run.

However, I would prefer to have the Valgrind issue fixed by adding a suppression database, which I will take on after we get a reasonable CI service performance, so it could bear at least some load without annoying everyone, and after we make it officially available to everyone, which I consider more important.

For that I need the distro-independent and mock config timestamp patches in first.

Essential suite is very fast but it is unusable, because valgrind test is ignored.

Please fix it ASAP; This ticket has the highest priority.

I disagree about the ticket priority. Especially in view of how much time it took to get the CI patches in.

However, I just finished doing what I could think of for improving CI availability and am waiting for the patches to be accepted. I can as well start on Valgrind.

Fields changed

summary: contrib/ci/run script: Add possibility to ignore failed tests per distribution => contrib/ci/run script: Prepare suppression database for valgrind

Fields changed

summary: contrib/ci/run script: Prepare suppression database for valgrind => contrib/ci/run script: Prepare suppression database for valgrind test

Fields changed

status: new => assigned

Fields changed

milestone: NEEDS_TRIAGE => SSSD Continuous integration

Fields changed

component: SSSD => Continuous integration

Fields changed

rhbz: => 0

Fields changed

mark: => 0
resolution: => fixed
status: assigned => closed

Metadata Update from @lslebodn:
- Issue assigned to nkondras
- Issue set to the milestone: SSSD Continuous integration

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/3470

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata