#2103 carefully re-check patches for #2066
Closed: Invalid None Opened 10 years ago by pbrezina.

There were few things that wasn't entirely clear during review of #2066 patches, but I didn't remember why I did so (I worked on those patches for a long time and they were waiting on the list even longer). I will check the logic again during 1.11.2 cycle.


Fields changed

owner: somebody => pbrezina
status: new => assigned

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.12 beta
rhbz: => 0

Fields changed

milestone: SSSD 1.12 beta => SSSD 1.12.1

The code still works and the logic is sane.

The reason we've opened this ticket was to determine why I choose to create and use get_domains_head() instead of passing the main domain as a parameter. I believe there was no real problem with it, but it would require to propagate the main domain from the top all the way down through parameters and tevent states, which was not worth the troubles.

The function is now used on more places so I believe it was a good call in the end.

I'm closing this ticket.

resolution: => worksforme
status: assigned => closed

Metadata Update from @pbrezina:
- Issue assigned to pbrezina
- Issue set to the milestone: SSSD 1.12.1

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/3145

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata