#2054 Review if responder_cli pointers are actually needed
Closed: Invalid 4 years ago by pbrezina. Opened 10 years ago by jhrozek.

There are per-responder pointers in the back end code. Mostly they are unused except for nss_cli pointer which is used during backchannel requests. We should make sure these are needed or just dead code.


Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.14 beta
rhbz: => 0

Fields changed

mark: => 0
milestone: SSSD 1.14 beta => SSSD 1.15 beta
sensitive: => 0

Metadata Update from @jhrozek:
- Issue set to the milestone: SSSD Future releases (no date set yet)

7 years ago

Is it about pointer to struct array[] being returned and not used, and so on in other responders.
struct cli_protocol_version *register_cli_protocol_version(void) //'src/responder/pac/pacsrv_cmd.c'
{
static struct cli_protocol_version pac_cli_protocol_version[] = {
{1, "2011-04-12", "initial version"},
{0, NULL, NULL}
};
return pac_cli_protocol_version;
}

These pointers are needed in current code but it can be rewritten to use bus names instead ffrom 2.x.

Metadata Update from @pbrezina:
- Custom field design_review reset (from 0)
- Custom field mark reset (from 0)
- Custom field patch reset (from 0)
- Custom field review reset (from 0)
- Custom field sensitive reset (from 0)
- Custom field testsupdated reset (from 0)
- Issue status updated to: Open (was: Closed)

4 years ago

Metadata Update from @pbrezina:
- Custom field design_review adjusted to on (was: false)
- Custom field mark adjusted to on (was: false)
- Custom field patch adjusted to on (was: false)
- Custom field review adjusted to on (was: false)
- Custom field sensitive adjusted to on (was: false)
- Custom field testsupdated adjusted to on (was: false)
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

4 years ago

Metadata Update from @thalman:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

4 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/3096

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata