Learn more about these different git repos.
Other Git URLs
When dealing with tevent, we use EAGAIN to say that an asynchronous request continues and EOK when it's done. Sometimes the asynchronous request is not even started and we need to mark a tevent_req as finished (tevent_req_done()) before any callback is attached to it. To make sure the callback is executed in this case, tevent_req_post() is called.
Both tevent_req_done() and tevent_req_post() should be called only from _send() for better clarity.
Many sdap_nested_group* functions return wrong error codes, they either return correctly EOK or they return EOK instead of EAGAIN. However, in both situations, the value EOK is usually translated to EAGAIN in the caller.
This forces us to use tevent_req_done/post() deep in the call hierarchy, outside _send() function. We should rewrite the return codes to obey this rule.
Fields changed
summary: rewrite nested group processing so that only _send() functions call tevent_req_done() and tevent_req_post() => rewrite nested group processing to follow the tevent_req coding style
milestone: NEEDS_TRIAGE => SSSD 1.10 beta rhbz: => 0 type: defect => task
owner: somebody => pbrezina status: new => assigned
patch: 0 => 1
Fixed in master: - 02b2c04 - 755aee4
resolution: => fixed review: => 0 status: assigned => closed
Metadata Update from @pbrezina: - Issue assigned to pbrezina - Issue set to the milestone: SSSD 1.10 beta
SSSD is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in SSSD's github repository.
This issue has been cloned to Github and is available here: - https://github.com/SSSD/sssd/issues/2826
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Login to comment on this ticket.