#1232 Use of unininitialized value in sudosrv_cache_set_entry
Closed: Fixed None Opened 12 years ago by sgallagh.

We need to set ret = ENOMEM here.

90errno_t sudosrv_cache_set_entry(struct tevent_context *ev,
 91                                struct sudo_ctx *sudo_ctx,
 92                                hash_table_t *table,
 93                                struct sss_domain_info *domain,
 94                                const char *username,
 95                                size_t num_rules,
 96                                struct sysdb_attrs **rules,
 97                                time_t timeout)
 98{
 99    struct sudo_cache_entry *cache_entry = NULL;
100    hash_key_t *key = NULL;
101    hash_value_t value;
102    TALLOC_CTX *tmp_ctx = NULL;
103    struct tevent_timer *timer = NULL;
104    struct timeval tv;
CID 12579: Uninitialized scalar variable (UNINIT)Declaring variable "ret" without initializer.
105    errno_t ret;
106    int hret;
107
108    tmp_ctx = talloc_new(NULL);
At conditional (1): "tmp_ctx == NULL" taking the true branch.
109    if (tmp_ctx == NULL) {
110        goto done;
111    }
112

...

165done:
166    talloc_free(tmp_ctx);
Using uninitialized value "ret".
167    return ret;
168}

The same issue occurs in sudosrv_cache_lookup_internal as well.

coverity: 12579 => 12579, 12578

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.9.0
rhbz: => 0

Fields changed

owner: somebody => pbrezina
patch: 0 => 1
status: new => assigned

Fixed by:
- bd0e976 (master)
- 4c1e009 (sssd-1-8)

milestone: SSSD 1.9.0 => SSSD 1.8.1 (LTM)
resolution: => fixed
status: assigned => closed

Metadata Update from @sgallagh:
- Issue assigned to pbrezina
- Issue set to the milestone: SSSD 1.8.1 (LTM)

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/2274

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata