#1125 fix sudo review comments
Closed: Fixed None Opened 12 years ago by jhrozek.

This ticket tracks the improvements proposed in https://fedorahosted.org/pipermail/sssd-devel/2011-December/007929.html :

  • use the NULL_CHECK() macro everywhere in sudo sysdb code
  • use spaces around iterator variable in the for loop in sysdb_get_sudo_user_info()
  • move dbus_error_is_set() into if (!dbus_ret) { condition in be_sudo_handler()
  • return ret in the fail label in be_sudo_handler
  • the block commented out using #if 0 in ipa_get_id_options should say SDAP_SUDO_SEARCH_BASE instead of SDAP_NETGROUP_SEARCH_BASE
  • SDAP_SUDO_SEARCH_BASE needs to be added into search_base_options
  • the logic in ldap_get_sudo_options concerning defaulting to ldap_search_base if sudo_search_base is not set is backwards
  • remove /* TODO purge with filter */ in sdap_sudo_load_sudoers_done()
  • check that the username is NULL terminated in the SUDO responder
  • call dbus_message_unref if dbus_message_append_args fails in sudosrv_dp_refresh_send
  • rename sss_sudo_get_result to sss_sudo_send_recv because it does both sending and receiving

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.8 SUDO Support

Fields changed

owner: somebody => pbrezina

Fields changed

status: new => assigned

Fields changed

patch: 0 => 1

Fixed by f643754

resolution: => fixed
status: assigned => closed

Fields changed

rhbz: => 0

Metadata Update from @jhrozek:
- Issue assigned to pbrezina
- Issue set to the milestone: SUDO Support

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/2167

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata