#1094 compilation fails with -Werror=format-security
Closed: Fixed None Opened 12 years ago by kklimonda2.

src/db/sysdb.c: In function 'sysdb_upgrade_01':
src/db/sysdb.c:820:22: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: some warnings being treated as errors

and another one:

src/db/sysdb_search.c: In function 'sysdb_enumgrent':
src/db/sysdb_search.c:361:22: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: some warnings being treated as errors


Fix compilation error by adding a format string to ldb_search calls
use-format-string.patch

The fix looks good to me. Thank you very much for your contribution!

Would you mind attaching a git-formatted patch or sending it to sssd-devel@lists.fedorahosted.org, mostly so we get your name and e-mail in the SCM history right?

Fixed by:
- 87c9241 (master)
- 4005d6d (sssd-1-6)
- ee2e225 (sssd-1-5)

Thank you very much for the patch, Krzysztof!

component: SSSD => SysDB
milestone: NEEDS_TRIAGE => SSSD 1.5.16
priority: major => minor
resolution: => fixed
status: new => closed

Fields changed

rhbz: => 0

Metadata Update from @kklimonda2:
- Issue set to the milestone: SSSD 1.5.16

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/2136

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata