Hi, this patch includes two improvements to python spec template:
Thanks for considering.
[1] https://fedorahosted.org/fpc/ticket/327#comment:14
attachment 0001-Add-python3-subpackage-to-python-spec-template-expli.patch
The implementation looks pretty much ok, but I'd say the with_python3 definition should be replaced with %bcond_with python3 (on not fedora) and %bcond_without python3 (on fedora) and uses of it accordingly, see %bcond_* docs in /usr/lib/rpm/macros.
Replying to [comment:1 scop]:
Good point. Actually, this is implemented precisely according to Python packaging guidelines. This makes me wonder why the guidelines don't use bcond. I'd first have to dig into that and I've been burried so deep into other stuff lately, that I don't have any time for that. So if this is a blocker for merging, let's leave this bug open and I'll get to it in time.
I happened to need this template myself so pushed as [606506] and further tweaked in [ba6571].
Login to comment on this ticket.