#937 Please include system-config-date-1.9.33-1.fc10 in F10 final
Closed: Fixed None Opened 15 years ago by nphilipp.

Unfortunately I missed the freeze on Tuesday (vacation the week before, backlog) and therefore didn't get the latest translations into the package. On top of that I fixed requirements. It would be good to get the package in to have the most up to date translations in the Live media. I've tested the package locally and haven't seen it malfunctioning.


-1.

You must have cvs-import'd the new SRPM, because you nuked the fix I did in 1.9.32-2 to add Requires: usermode-gtk to fix a blocker bug. Please reapply this change and rebuild.

Replying to [comment:1 spot]:

-1.

You must have cvs-import'd the new SRPM, because you nuked the fix I did in 1.9.32-2 to add Requires: usermode-gtk to fix a blocker bug. Please reapply this change and rebuild.

Not really, I just did the fix in a more correct way upstream (by not requiring "usermode" at all, only "usermode-gtk" with the right version). I do read my Bugzilla email ;-).

You did revert/lose spot's changes, tho.

That said, +1

Replying to [comment:4 rdieter]:

You did revert/lose spot's changes, tho.[[BR]]
[[BR]]
That said, +1

I'd have thought that keeping the spirit of his changes (while not the exact way of doing it) should be acceptable, given that the unwritten constitution of this package clearly states that changes should only ever be done upstream ;-P. Expecting that changes made only in the Fedora CVS repository are incorporated upstream without changes is a bit much IMO.

BTW: Is there an agreed upon way to make this clear for Fedora packages, i.e. "Make your changes upstream at the ... repository instead of here. If this is not possible, notify the author at ..."?

Login to comment on this ticket.

Metadata