Ticket #1 (new defect)

Opened 2 years ago

erroneous "return NULL" in krb5module.c:make_principal

Reported by: dmalcolm Owned by: somebody
Priority: major Milestone:
Component: component1 Version:
Keywords: Cc:
Blocked By: Blocking:

Description

static PyObject *
make_principal(PyObject *ctx_obj, krb5_context ctx, krb5_principal orig_princ)

has:

  if(!orig_princ)
    {
      Py_INCREF(Py_None);
      return NULL;
    }

This should read:

 if(!orig_princ)
    {
      Py_INCREF(Py_None);
      return Py_None;
    }

Found using a static analysis tool: http://readthedocs.org/docs/gcc-python-plugin/en/latest/cpychecker.html

Attachments

krb5module.c.make_principal-refcount-errors.html (27.1 KB) - added by dmalcolm 2 years ago.
HTML report showing the error

Change History

Changed 2 years ago by dmalcolm

HTML report showing the error

Note: See TracTickets for help on using tickets.