Ticket #66 (reopened defect)

Opened 3 years ago

Last modified 22 months ago

preupgrade-cli from HEAD doesn't work, needs two-line patch

Reported by: mtd Owned by: rhughes
Priority: major Milestone: 1.0
Component: preupgrade-cli Version: 1.1.x
Keywords: Cc:
Blocked By: Blocking:

Description

preupgrade-cli.py needs to inherit from YumBaseCli? and call that superclass's constructor. Presumably in F12 and later something changed in yum's python code.

Downstream bug is https://bugzilla.redhat.com/show_bug.cgi?id=615640 , patch is from http://www.wilyness.com/blog/?p=137 , muliple howls on the internet exist (google for the error message "AttributeError?: 'PreUpgradeCli?' object has no attribute 'yum_cli_commands'").

Change History

comment:1 Changed 3 years ago by mtd

  • Resolution set to fixed
  • Status changed from new to closed

rhughes has applied the patch - closing. Thanks for fixing.

comment:2 Changed 2 years ago by mtd

  • Resolution fixed deleted
  • Status changed from closed to reopened

I'm not sure what the protocol is about re-opening, so apologies if I'm not supposed to do it, but this patch was not applied. I think my earlier, proposed patch included in redhat's bugzilla was. Unfortunately that patch was wrong.

I will attach a new patch that reverts the applied patch and applies the original patch.

comment:3 Changed 2 years ago by mtd

The two patches can easily be applied to current git HEAD via:

curl https://fedorahosted.org/preupgrade/attachment/ticket/66/0066-Revert-Fix-preupgrade-cli-after-a-yum-API-change.patch?format=raw | git am
curl https://fedorahosted.org/preupgrade/attachment/ticket/66/0067-Really-fix-preupgrade-cli-after-a-yum-API-change.patch?format=raw | git am

I've tested the changed preupgrade-cli.py on my F15 box, for good measure, to be sure it works. It works.

comment:5 Changed 22 months ago by wangd

It looks like the patch got applied properly in 07f3924c27ab80e3992b2ae3bea9a292c82e3bf8 .

Note: See TracTickets for help on using tickets.