The following comments came from edewata:

In the HttpConnection.java, send() function needs better error handling:

• The HttpConnection.send() checks for untrusted certificate by checking the exception message. This may work now but could become inaccurate later due to translation, text changes, or typo. It would be better if there's a specific exception type or error code that we can check for this specific case.

• HttpConnection.send() swallows NumberFormatException. I think we should not catch this to detect the error as early as possible and also NumberFormatException is already a RuntimeException so it doesn't need to be wrapped/declared.

• HttpConnector.send() (not HttpConnection) would swallow the exception so some errors wouldn't be detected immediately. I think the code could be simplified as follows (the send() already throws EBaseException):

  try {
  curConn = mConnFactory.getConn(op);
  return curConn.send(msg);

  } finally {
  if (curConn != null) {
  mConnFactory.returnConn(curConn);
  }
  }