With the current pkgdb web, if one sets Approved for "Fedora devel" then all other branches get marked for approval too, even unrequested branches. I don't think this is a good feature - rather assume it is a bug. There could be a separate button at the end of the row: "Approval all branches" say if this is desirable.
This is a feature that has been requested here: https://github.com/fedora-infra/pkgdb2/issues/84
I see - would it not be better as a separate button: "[Approve all]"?
I forget: is this ticket okay or do you prefer a github issue?
The Approve all is present on the My Request page whose link is at the top
My Request
I don't mean All requests, but all ACL requests from one person for a particular package. (I didn't request the feature - I am saying the new behaviour is a regression.:)
Speaking on IRC with Vít, I became confuse: is the problem the fact that we automatically change the field or that we automatically change all the fields (ie: even the not-requested ones)?
If it's the later that's way easier to fix :)
To only automatically change the 'Awaiting Review' branch, it's a one-liner :)
I have updated https://admin.stg.fedoraproject.org/pkgdb/ manually for the new behavior, feel free to test it there to see if it fixes you request.
Thanks Pingo - it is definitely an improvement. :)
The thing is sometimes I don't want people to be able to touch older stable branches (generally trying to discourage updating stable releases for Haskell unless really necessary) so to avoid accidents I might only want to give someone commit access to master initially or maybe latest branch too but maybe not older releases. At least now it will no longer try to approve more branches than were requested but still it means more clicks for me... I guess one can't please everyone one: but still I find the new behaviour violates the principle of "least surprise". So I think better to add an "All requested branches" column for acting on multiple branch requests.
In these case I just use tabs and adjust the ones I don't want to change.
I think I will go with the current behavior shown in stg as a middle ground between both requests.
If more people are un-happy with the behavior, I'm of course willing to change my mind, but I find the current (new) situation a good middle-ground :)
Btw the change is up for review at: https://github.com/fedora-infra/pkgdb2/pull/259
And merged :)
Login to comment on this ticket.