I'm trying to retire OpenStack Folsom packages from EPEL6 and I managed to push dead.package but pkgdb part fails on permissions even where I am either package admin or main contact
e.g. package admin https://admin.fedoraproject.org/pkgdb/package/python-keystoneclient/ $ pkgdb-cli orphan --retire python-keystoneclient el6 You are not allowed to change the point of contact.
e.g. package main contact https://admin.fedoraproject.org/pkgdb/package/python-swiftclient/ $ pkgdb-cli orphan --retire python-swiftclient el6 user: apevec changed point of contact of package: python-swiftclient from: apevec to: orphan on branch: el6 You are not allowed to retire the package: python-swiftclient on branch el6.
Who is allowed to retire a package?
Rel-eng: https://fedorahosted.org/rel-eng/ is the group that can handle retirement.
But I wonder if there isn't still a problem here. You should be able to retire on EPEL branches.
Thanks for the report, I'll investigate this.
Sorry forgot to reply to the first part:
e.g. package admin https://admin.fedoraproject.org/pkgdb/package/python-keystoneclient/ $ pkgdb-cli orphan --retire python-keystoneclient el6 You are not allowed to change the point of contact.
That one is normal, only the point of contact can retire a non-orphaned package.
So I've pestered all Main Contacts for openstack-* and they all get the same error. Branch ends up as Orphaned and anyone can take it.
Here's example where I was Main Contact: $ pkgdb-cli orphan --retire openstack-keystone el6 user: apevec changed point of contact of package: openstack-keystone from: apevec to: orphan on branch: el6 You are not allowed to retire the package: openstack-keystone on branch el6.
Reading this again, could it be that contact is changed prematurely? When retire permission is checked, contact is already set to orphan!
Yeah I thought this was a problem, so I fixed this in pkgdb-cli but only in git and I can't make a release atm as there is one pending on updates-testing for few days already.
Feel free to test the git version though if you like.
However, I am trying to duplicate the issue in unit-tests in pkgdb2 and so far with no luck, I'll keep trying.
Sorry for the inconvenience
I applied https://git.fedorahosted.org/cgit/packagedb-cli.git/commit/?id=468f48daef9630afadc596ffc1aa09ea6d9233fe and the output is now (after retaking el6 branch):
$ pkgdb-cli orphan --retire openstack-keystone el6 You are not allowed to retire the package: openstack-keystone on branch el6.
So premature orphaning is not happening but pkgdbclient.retire_packages still fails on permission check.
Could you check on the pkgdb2 backend which permission check is actually failing?
https://git.fedorahosted.org/cgit/pkgdb2.git/tree/pkgdb2/lib/__init__.py#n504 or collection.name == 'EPEL':
But https://admin.fedoraproject.org/pkgdb/api/collections returns "name": "Fedora EPEL" for el6 branch!?
Oh boy... how did I miss that?
I'll fix that and push a new release later today
PS: thanks for finding it out!!
and we are later today :)
I just push 1.18.2 which fixes this.
Thanks, I've successfully retired openstack-keystone el6 branch with patched pkgdb-cli and 1.18.2 backend!
$ pkgdb-cli orphan --retire openstack-keystone el6 user: apevec updated package: openstack-keystone status from: Approved to Retired on branch: el6
Great! Thanks for your help :)
Looks like we have a regression in epel7
https://bugzilla.redhat.com/show_bug.cgi?id=1249138#c4
So this isn't a bug in pkgdb, epel7 is set to not allow retirement: https://admin.fedoraproject.org/pkgdb/collection/epel7/
I've asked if this is intended or not.
Ok, epel7 has been adjusted, could you try again?
Worked, thanks! user: apevec updated package: python-jsonpointer status from: Approved to Retired on branch: epel7
Login to comment on this ticket.