#722 Unchecked return values in SLAPI plugins
Closed: Fixed None Opened 13 years ago by jhrozek.

In daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c:

704            Slapi_Attr *attr = NULL;
No check of the return value of "slapi_entry_attr_find(entries[0], attrname, &attr)".
 705            slapi_entry_attr_find(entries[0], attrname, &attr);

In daemons/ipa-slapi-plugins/ipa-uuid/ipa_uuid.c:

 817        if (tmp_dn) {
No check of the return value of "slapi_search_internal_get_entry(tmp_dn, NULL, &e, getPluginID())".
 818            slapi_search_internal_get_entry(tmp_dn, NULL, &e, getPluginID());

In daemons/ipa-slapi-plugins/ipa-uuid/ipa_uuid.c:

 968                        int e_numvals = 0;
 969
No check of the return value of "slapi_entry_attr_find(e, attr, &sattr)".
 970                        slapi_entry_attr_find(e, attr, &sattr);

In daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c

 749                const char *strval;
 750
No check of the return value of "slapi_attr_first_value(sattr, &val)".
 751                slapi_attr_first_value(sattr, &val);

In daemons/ipa-kpasswd/ipa_kpasswd.c

No check of the return value of "ber_printf(ctrl, "{tstO}", 128UL, userdn, 130UL, &newpw)".
Calling function "ber_printf" without checking return value (as is done elsewhere 15 out of 17 times).
 486        ber_printf(ctrl, "{tstO}",
 487                   LDAP_TAG_EXOP_MODIFY_PASSWD_ID, userdn,
 488                   LDAP_TAG_EXOP_MODIFY_PASSWD_NEW, &newpw);

Metadata Update from @jhrozek:
- Issue assigned to mkosek
- Issue set to the milestone: FreeIPA 2.0 - 2011/01 (cleanup)

7 years ago

Login to comment on this ticket.

Metadata