#6185 Fix messages tests in ipa.test_ipalib
Closed: Fixed None Opened 7 years ago by mbasti.

Messages now contain the 'data' attribute, this change should be reflected in tests.

>       assert result == {'messages': [
            dict(
                name='HelloMessage',
                type='info',
                message='Hello, world!',
                code=1234,
            ),
            dict(
                name='HelloMessage',
                type='info',
                message='Hi, version!',
                code=1234,
            )
        ]}
E       assert {'messages': ...ssage', ...}]} == {'messages': [...pe': 'info'}]}
E         Differing items:
E         {'messages': [{'code': 1234, 'data': {'greeting': 'Hello', 'object': 'world'}, 'message': 'Hello, world!', 'name': 'He...code': 1234, 'data': {'greeting': 'Hi', 'object': 'version'}, 'message': 'Hi, version!', 'name': 'HelloMessage', ...}]} != {'messages': [{'code': 1234, 'message': 'Hello, world!', 'name': 'HelloMessage', 'type': 'info'}, {'code': 1234, 'message': 'Hi, version!', 'name': 'HelloMessage', 'type': 'info'}]}
E         Full diff:
E         {'messages': [{'code': 1234,
E         -                'data': {'greeting': u'Hello', 'object': u'world'},
E         -                'message': u'Hello, world!',
E         ?                           -
E         +                'message': 'Hello, world!',
E         -                'name': u'HelloMessage',
E         ?                        -
E         +                'name': 'HelloMessage',
E         -                'type': u'info'},
E         ?                        -
E         +                'type': 'info'},
E         {'code': 1234,
E         -                'data': {'greeting': u'Hi', 'object': u'version'},
E         -                'message': u'Hi, version!',
E         ?                           -
E         +                'message': 'Hi, version!',
E         -                'name': u'HelloMessage',
E         ?                        -
E         +                'name': 'HelloMessage',
E         -                'type': u'info'}]}
E         ?                        -
E         +                'type': 'info'}]}

master:

  • 71d0bc7 Tests: Add data attribute to messages

Metadata Update from @mbasti:
- Issue assigned to lryznaro
- Issue set to the milestone: FreeIPA 4.4.1

7 years ago

Login to comment on this ticket.

Metadata