Issue #5841: upgrade: find_hostname() method should be replaced by api.env.host - freeipa

freeipa

#5841 upgrade: find_hostname() method should be replaced by api.env.host

Closed: Fixed None Opened 8 years ago by mbasti.

The method find_hostname in upgrade is parsing "/etc/httpd/conf.d/ipa-rewrite.conf" file to get hostname. This value is used everywhere in upgrade.

I don't think that using this method is save or efficient, since we have api.env.host variable that provides the hostname.

Introduced in 4699fc5, 8e7561c

IMO

mbasti commented 7 years ago

master:

8659357 Replaced find_hostname with api.env.host

Metadata Update from @mbasti:
- Issue assigned to someone
- Issue set to the milestone: FreeIPA 4.4

7 years ago

Metadata

Assignee

someone

Tags

None

Blocking

None

Depending on

None

Priority

normal

Milestone

FreeIPA 4.4

None

affects_doc

None

source

None

knownissue

None

type

refactoring

blockedby

None

test_case

None

component

IPA

blocking

None

on_review

keywords

easyfix

test_coverage

None

reviewer

mbasti

external_tracker

None

rhbz

tester

None

changelog

None

design

None

freeipa

Source Code

#5841 upgrade: find_hostname() method should be replaced by api.env.host Closed: Fixed None Opened 8 years ago by mbasti.

Metadata

#5841 upgrade: find_hostname() method should be replaced by api.env.host

Closed: Fixed None Opened 8 years ago by mbasti.