#5740 ipa-replica-prepare: Traceback if reverse zone does not exists
Closed: Fixed None Opened 8 years ago by mbasti.

Method bindinstance.find_reverse_zone(ip) returns None if there is no reverse zone in LDAP. There is no check for None value and code blows up later.

            if not options.no_reverse:
                reverse_zone = bindinstance.find_reverse_zone(ip)
                try:
                    add_ptr_rr(reverse_zone, ip_address, self.replica_fqdn)
                except errors.PublicError as e:
                    raise admintool.ScriptError(
                        "Could not add PTR DNS record for the replica: %s"
                        % e)

Regression caused by 4.3 patches that caused a reverse zone is not created automatically.

IMO we should continue with replica-prepare if there is no reverse zone in LDAP.


I can imagine two scenarios here:
- print warning and skip record creation
- error out forcing user to create the zone or pass --no-reverse

User can always create zone and records later if he really cares so I agree with Martin.

master:

  • 6baed5b replica-prepare: do not add PTR records if there is no IPA managed reverse zone

ipa-4-3:

  • 192a8e3 replica-prepare: do not add PTR records if there is no IPA managed reverse zone

Metadata Update from @mbasti:
- Issue assigned to mbabinsk
- Issue set to the milestone: FreeIPA 4.3.2

7 years ago

Login to comment on this ticket.

Metadata