#5640 Framework does not respect sizelimit passed via webUI in some searches
Closed: Fixed None Opened 8 years ago by mbasti.

Steps to reproduce:
1. set sizelimit to 2
1. show permissions in webUI
1. LimitsExceeded error is raised, but webUI passes sizelimit=0 which should prevent to raise LimitsExceeded due sizelimit

Traceback

[Tue Jan 26 14:59:46.874450 2016] [wsgi:error] [pid 28686] ipa: DEBUG: WSGI wsgi_execute PublicError: Traceback (most recent call last):
[Tue Jan 26 14:59:46.874515 2016] [wsgi:error] [pid 28686]   File "/usr/lib/python2.7/site-packages/ipaserver/rpcserver.py", line 350, in wsgi_execute
[Tue Jan 26 14:59:46.874521 2016] [wsgi:error] [pid 28686]     result = self.Command[name](*args, **options)
[Tue Jan 26 14:59:46.874524 2016] [wsgi:error] [pid 28686]   File "/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 446, in __call__
[Tue Jan 26 14:59:46.874526 2016] [wsgi:error] [pid 28686]     ret = self.run(*args, **options)
[Tue Jan 26 14:59:46.874528 2016] [wsgi:error] [pid 28686]   File "/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 763, in run
[Tue Jan 26 14:59:46.874530 2016] [wsgi:error] [pid 28686]     return self.execute(*args, **options)
[Tue Jan 26 14:59:46.874532 2016] [wsgi:error] [pid 28686]   File "/usr/lib/python2.7/site-packages/ipalib/plugins/permission.py", line 1250, in execute
[Tue Jan 26 14:59:46.874534 2016] [wsgi:error] [pid 28686]     return super(permission_find, self).execute(*keys, **options)
[Tue Jan 26 14:59:46.874535 2016] [wsgi:error] [pid 28686]   File "/usr/lib/python2.7/site-packages/ipalib/plugins/baseldap.py", line 2087, in execute
[Tue Jan 26 14:59:46.874537 2016] [wsgi:error] [pid 28686]     truncated = callback(self, ldap, entries, truncated, *args, **options)
[Tue Jan 26 14:59:46.874539 2016] [wsgi:error] [pid 28686]   File "/usr/lib/python2.7/site-packages/ipalib/plugins/permission.py", line 1311, in post_callback
[Tue Jan 26 14:59:46.874541 2016] [wsgi:error] [pid 28686]     attrs_list=attrs_list)
[Tue Jan 26 14:59:46.874542 2016] [wsgi:error] [pid 28686]   File "/usr/lib/python2.7/site-packages/ipapython/ipaldap.py", line 1263, in get_entries
[Tue Jan 26 14:59:46.874544 2016] [wsgi:error] [pid 28686]     raise errors.LimitsExceeded()
[Tue Jan 26 14:59:46.874546 2016] [wsgi:error] [pid 28686] LimitsExceeded: limits exceeded for this query

Please note this may happen for multiple commands not just for permissions


Just note, this might be TimeExceeded error masked as Sizelimit

This ticket is out of scope of 4.4.0 release. Moving to 4.4.1. Note that 4.4.1 needs to be triaged, therefore not everything will be implemented.

Moving to next major version. Fixing this bug is not critical in stabilization release.

master:

  • 0df65b6 Make get_entries() not ignore its limit arguments
  • 29aa487 fix permission_find fail on low search size limit
  • 2663a96 permission-find: fix a sizelimit off-by-one bug

These changes introduced another issue when size limit exceeding is announced when an argument is passed along with specifying --size-limit.

master:

  • 0c044cb Generalize filter generation in LDAPSearch
  • a77627d Fix permission-find with sizelimit set

Metadata Update from @mbasti:
- Issue assigned to stlaz
- Issue set to the milestone: FreeIPA 4.5

7 years ago

Login to comment on this ticket.

Metadata