Issue #5467: current style of implementation of Tracker classes leads to cyclic imports - freeipa

freeipa

#5467 current style of implementation of Tracker classes leads to cyclic imports

Closed: Fixed None Opened 8 years ago by mkubik.

# ipa console
(Custom IPA interactive Python console)
>>> from ipatests.test_xmlrpc.test_group_plugin import GroupTracker
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/usr/lib/python2.7/site-packages/ipatests/test_xmlrpc/test_group_plugin.py", line 35, in <module>
    from ipatests.test_xmlrpc.test_user_plugin import UserTracker
  File "/usr/lib/python2.7/site-packages/ipatests/test_xmlrpc/test_user_plugin.py", line 42, in <module>
    from ipatests.test_xmlrpc.test_group_plugin import GroupTracker
ImportError: cannot import name GroupTracker

Currently the tracker class is implemented in the test module of its respective plugin. This creates a possibility of circular imports as shown in the stack trace.

mbasti commented 8 years ago

master:

17f9ca1 Separated Tracker implementations into standalone package

Metadata Update from @mkubik:
- Issue assigned to mkubik
- Issue set to the milestone: FreeIPA 4.3

7 years ago

Metadata

Assignee

mkubik

Tags

None

Blocking

None

Depending on

None

Priority

normal

Milestone

FreeIPA 4.3

None

affects_doc

None

source

None

knownissue

None

type

defect

blockedby

None

test_case

None

component

Tests

blocking

None

on_review

keywords

None

test_coverage

None

reviewer

amarecek

external_tracker

None

rhbz

tester

None

changelog

None

design

None

freeipa

Source Code

#5467 current style of implementation of Tracker classes leads to cyclic imports Closed: Fixed None Opened 8 years ago by mkubik.

Metadata

#5467 current style of implementation of Tracker classes leads to cyclic imports

Closed: Fixed None Opened 8 years ago by mkubik.