#4797 More validation required on ipa-restore's options
Closed: Fixed None Opened 9 years ago by ksiddiqu.

(1)Restore from data backup without --data option

[root@dhcp207-214 backup]# ipa-restore -p xxxxxxxx /var/lib/ipa/backup/ipa-data-2014-12-10-17-47-50/ -U
Preparing restore from /var/lib/ipa/backup/ipa-data-2014-12-10-17-47-50/ on dhcp207-214.testrelm.test
Each master will individually need to be re-initialized or
re-created from this one. The replication agreements on
masters running IPA 3.1 or earlier will need to be manually
re-enabled. See the man page for details.
Disabling all replication.
Disabling replication agreement on dhcp207-133.testrelm.test to dhcp207-214.testrelm.test
Stopping IPA services
Restoring from userRoot in TESTRELM-TEST
Restoring from ipaca in TESTRELM-TEST
Starting IPA services
Restarting SSSD
The ipa-restore command was successful
[root@dhcp207-214 backup]#

Here restore is happening similar to restore from full backup but actually from data backup and that too without --data option. I am expecting that restore should fail and prompt an error message (or atleast a warning message) that --data option must be used with restore data backup.

Related one with --online option

[root@dhcp207-214 backup]# ipa-restore -p xxxxxxxx --online /var/lib/ipa/backup/ipa-data-2014-12-10-17-47-50/ -U
Preparing restore from /var/lib/ipa/backup/ipa-data-2014-12-10-17-47-50/ on dhcp207-214.testrelm.test
Each master will individually need to be re-initialized or
re-created from this one. The replication agreements on
masters running IPA 3.1 or earlier will need to be manually
re-enabled. See the man page for details.
Disabling all replication.
Disabling replication agreement on dhcp207-133.testrelm.test to dhcp207-214.testrelm.test
Stopping IPA services
Restoring from userRoot in TESTRELM-TEST
Unable to bind to LDAP server: cannot connect to 'ldapi://%2fvar%2frun%2fslapd-TESTRELM-TEST.socket': 
Restoring from ipaca in TESTRELM-TEST
Unable to bind to LDAP server: cannot connect to 'ldapi://%2fvar%2frun%2fslapd-TESTRELM-TEST.socket': 
Starting IPA services
Restarting SSSD
The ipa-restore command was successful
[root@dhcp207-214 backup]#

Here expecting an error message that --online option can only provided along with --data option.

(2)Restore with --no-logs option from data backup

[root@dhcp207-214 backup]# ipa-restore -p xxxxxxxx --data /var/lib/ipa/backup/ipa-data-2014-12-10-17-38-58/ --no-logs -U
Preparing restore from /var/lib/ipa/backup/ipa-data-2014-12-10-17-38-58/ on dhcp207-214.testrelm.test
Each master will individually need to be re-initialized or
re-created from this one. The replication agreements on
masters running IPA 3.1 or earlier will need to be manually
re-enabled. See the man page for details.
Disabling all replication.
Disabling replication agreement on dhcp207-133.testrelm.test to dhcp207-214.testrelm.test
Stopping Directory Server
Restoring from userRoot in TESTRELM-TEST
Restoring from ipaca in TESTRELM-TEST
Starting Directory Server
The ipa-restore command was successful
[root@dhcp207-214 backup]#

Here restore should fail prompting an error message (or warning message at least) that --no-logs option can not be used with --data

(3)Non-existent ds instance in --instance

[root@dhcp207-214 ~]# ipa-restore --data -p xxxxxxxx --instance=TESTRELM-TEST1 /var/lib/ipa/backup/ipa-full-2014-12-11-13-17-59/
Preparing restore from /var/lib/ipa/backup/ipa-full-2014-12-11-13-17-59/ on dhcp207-214.testrelm.test
No instances to restore to
[root@dhcp207-214 ~]#

Expecting error message : "Instance TESTRELM-TEST1 does not exist"

Similarly for --backend option

[root@dhcp207-214 ~]# ipa-restore --data -p xxxxxxxx --backend=userRoot1 /var/lib/ipa/backup/ipa-full-2014-12-11-13-17-59/
Preparing restore from /var/lib/ipa/backup/ipa-full-2014-12-11-13-17-59/ on dhcp207-214.testrelm.test
No instances to restore to
[root@dhcp207-214 ~]#

Expecting error message : "Backend userRoot1 does not exist"


At least 1) should be fixed, it can confuse people.

All issues except 2. (benign) fixed:

master:

  • 10fe918 Fix validation of ipa-restore options

ipa-4-1:

  • 6950e7b Fix validation of ipa-restore options

master branch regression fixed:

master:

  • 35c4fa2 Fix IPA_BACKUP_DIR path name

Metadata Update from @ksiddiqu:
- Issue assigned to jcholast
- Issue set to the milestone: FreeIPA 4.1.3

7 years ago

Login to comment on this ticket.

Metadata