#4258 Disabled action buttons are focusable
Closed: Fixed None Opened 10 years ago by pvoborni.

Easy fix would be to add:
{{{button.attr('tabindex', -1)}}} and {{{button.removeAttr('tabindex')}}} next to each instance of {{{button.addClass('action-button-disabled')}}} resp. {{{button.removeClass('action-button-disabled')}}}

Proper fix would be to refactor usage of IPA.action_button into new IPA.action_button_widget and use the above only on one place.

The same code for disabling/enabling functionality is already used at 8 places.


Partially fixed in PatternFly adoption. Facet buttons are implemented as normal button therefore doesn't suffer from this issue.

It's still present in association tables.

Moving stabilization tickets that do not affect FreeIPA 4.0 release usability in any significant way to 4.0.1 stabilization milestone.

FreeIPA 4.0.1 was released, moving to next bugfixing release milestone.

master:

  • 3966417 webui: replace action_buttons with action_widget
  • ac7df79 webui: remove remaining action-button-disabled occurrences

ipa-4-1:

  • 3966417 webui: replace action_buttons with action_widget
  • ac7df79 webui: remove remaining action-button-disabled occurrences

ipa-4-0:

  • 9cbe6b1 webui: replace action_buttons with action_widget
  • bf9c254 webui: remove remaining action-button-disabled occurrences

CI fix:

ipa-4-0:

  • 4582f48 webui-ci: fix table widget add

ipa-4-1:

  • 4fde716 webui-ci: fix table widget add

master:

  • a3c51e2 webui-ci: fix table widget add

Metadata Update from @pvoborni:
- Issue assigned to pvoborni
- Issue set to the milestone: FreeIPA 4.0.2

7 years ago

Login to comment on this ticket.

Metadata