#358 Run IPA through code analizer tools
Closed: Fixed None Opened 13 years ago by dpal.

Use available code analyzing tools and run tests before release.


In ticket #120 you closed it because this ticket contains a broader list of tools. What are those tools?

We can use Coverity to scan our C/C++ codebase. We can use LLVM's clang (available in Fedora) for these languages, too. pylint is a nice tool for python, although I think we'd need to tune its output a little (no warnings about missing docstring of every method, no warnings about lines too long etc.). A quick google search revealed that there is a tool called jslint for checking JavaScript, although I would defer this part to someone who actually speaks JS :-)

I believe that the UI has already been passed through jslint at least once.

Closing this ticket since we scanned the codebase with pylint, Coverity and jslint. We have set up periodic scans with Coverity.

There is still one more task to do - set up pylint scans for errors, ideally during build time. But due to very dynamic nature of Python (and our usage), the default scanners produce a big number of false positives. I'll file a new ticket for a later release.

pylint errors fixed in ab2ca80
Coverity tickets have the 'Coverity' keyword
jslint fix is 2b50853

Metadata Update from @dpal:
- Issue assigned to jhrozek
- Issue set to the milestone: FreeIPA 2.0 - 2011/01 (cleanup)

7 years ago

Login to comment on this ticket.

Metadata