#3313 cookie library does not parse nor generate expires attribute correctly when locale is not english
Closed: Fixed None Opened 11 years ago by jdennis.

The Expires attribute in a cookie is supposed to follow the RFC 822 (superseded by RFC 1123) date format. That format includes a weekday abbreviation (e.g. Tue) which must be in English according to the RFC's.

ipapython/cooke.py has methods to parse and format the Expires attribute but they were based on strptime() and strftime() which respects the locale. If a non-English locale is in effect the wrong date string will be produced and/or it won't be able to parse the date string.

The fix is to use the date parsing and formatting functions from email.utils which specifically follow the RFC's and are not locale sensitive.


patch submitted

[PATCH 83] Cookie Expires date should be locale insensitive

The patch should be applied to the following branches:

master, 3.0, 3.1

master: 159b681[[BR]]
ipa-3-1: 8a981c0[[BR]]
ipa-3-0: bcda90f

Metadata Update from @jdennis:
- Issue assigned to jdennis
- Issue set to the milestone: 0.0 NEEDS_TRIAGE

7 years ago

Login to comment on this ticket.

Metadata