Issue #3172: Re-adding an existing entry in trust, does not throw exception. - freeipa

freeipa

#3172 Re-adding an existing entry in trust, does not throw exception.

Closed: Fixed None Opened 11 years ago by mvarun.

Steps to Reproduce in WebUI:
Add existing Trust as follows:
1.Select Add in IPA Server Trusts
2.Enter AD Domain
3.Select Administrator Account
4.Enter existing Account and password

Actual results in Web UI:
Trust Established and verified.

Step to Reproduce in CLI:
Add existing trust again and again
#ipa trust-add --type=ad mvarun.com --admin administrator --password
Active directory domain administrator's password:

#ipa trust-add --type=ad mvarun.com --admin administrator --password
Active directory domain administrator's password:

Actual results in CLI:
---------------------------------------------------
Added Active Directory trust for realm "mvarun.com"
---------------------------------------------------
  Realm name: mvarun.com
  Domain NetBIOS name: MVARUN
  Domain Security Identifier: S-1-5-21-3517319380-3484331254-4086128528
  Trust direction: Two-way trust
  Trust type: Active Directory domain
  Trust status: Established and verified

---------------------------------------------------
Added Active Directory trust for realm "mvarun.com"
---------------------------------------------------
  Realm name: mvarun.com
  Domain NetBIOS name: MVARUN
  Domain Security Identifier: S-1-5-21-3517319380-3484331254-4086128528
  Trust direction: Two-way trust
  Trust type: Active Directory domain
  Trust status: Established and verified

Expected results in WebUI and CLI:

trust-add for existing trust should return error "trust already exists" instead of modifying it.

dpal commented 11 years ago

This is invalid. As discussed in the thread the expectation is wrong. The command updates the same trust with new credentials. The man page has been already updated to set the correct expectations.