#3035 Reevaluation of confirmation of actions in Web UI.
Closed: Fixed None Opened 11 years ago by pvoborni.

This is about whether to display a confirmation dialog before executing an action depending on it's type and location. This ticket should also serve as a reference point when implementing new actions.

We have 3 places where can be actions located: action list (drop down in page header), control buttons bar (bar under page title and navigation) and action panels (panel on the right side of a section).

After a talk with Dmitri, general idea is:

Show confirmation for:
1. Batch operations which are changing data like deleting/enabling/disabling of multiple items in search pages.
2. Actions which are changing data and are located in control buttons bar or action panel except 'Update' (besides batch actions in 1) there are none at the moment)

Don't show confirmation for:
1. Actions which are selected from action list. Selection of an item in the list can be considered as a confirmation itself.
2. 'Update' action in details pages. This wasn't in 2.2, is in 3.0. Can be easily removed.
3. Actions which are not changing data (refresh, reset)
4. Actions which are changing data but where exist a middle step which needs user's input eg: add, reset password, issue cert...

With current implementation it basically means to do following changes:
1. remove confirmation from update action
2. add confirmation for batch actions - this will be side effect of patch for #2977
3. reset action list to show '-- select action --' on page refresh. It forces user to select the action. Now it shows the last selected action even when item changes.
4. implement and use custom confirmation dialog. Using window.alert JS call is not consistent with the rest of the UI.

Notification of action success is a responsibility of #2977.

Comments are welcome.


IMHO it should be configurable per-user. Admins usualy know what they do and unnecessary (from their point of view) dialogs are making admins crazy.

The core of this ticket was implemented and pushed.

There appeared an inconsistency in confirmation of the dialogs by default key (Enter). New confirmation dialog has it, older ones don't. Older dialogs should be improved to have it. Therefore leaving open and moving to RC2.

FreeIPA 3.0.0 GA has been released, moving the ticket to 3.0 bugfixing release.

Closing this ticket as the core was already implemented in 3.0 RC2. The remaining issue was separated to its own ticket - #3200 to better understand what's missing. It won't be addressed in 3.0.1 as it is more complicated than it seems and may introduce new bugs which goes against 'bugfixing release' purpose.

Metadata Update from @pvoborni:
- Issue assigned to pvoborni
- Issue set to the milestone: FreeIPA 3.0.1 (bug fixing)

7 years ago

Login to comment on this ticket.

Metadata