We have 2 booleans to restore during uninstall and we do them separately rather than in a single step. This doubles the amount of time it takes to uninstall to several minutes. We should combine them into a single call.
proposed patch, will submit to devel when triaged freeipa-rcrit-1037-uninstall.patch
no visual impact, regression testing will cover if something is broken
I see the ticket is triaged and targeted to RC2. Rob, can you please submit a rebased patch to devel list?
attachment freeipa-rcrit-1037-2-uninstall.patch
Petr Viktorin pointed out that we could re-use a bit of code in the httpinstance installer and avoid some duplication/similar code.
I agree that this is a good idea but the changes would be rather invasive and require a lot of additional testing. At this point in the cycle I don't think it is worth it. For a customer uninstall is a rare occurrence and we have lived with this in dev for this long, a little big longer won't kill us.
Pushing to 3.2
attachment freeipa-abbra-0085-Avoid-modifying-SELinux-variables-when-they-already-.patch
One more patch to combine, this time in adtrustinstance.
This ticket was fixed during development of #4157.
master:
ipa-4-1:
Metadata Update from @rcritten: - Issue assigned to pviktori - Issue set to the milestone: FreeIPA 4.1
Login to comment on this ticket.