Issue #2644: Improve migration plugin error when 2 groups have identical GID - freeipa

freeipa

#2644 Improve migration plugin error when 2 groups have identical GID

Closed: Fixed None Opened 12 years ago by mkosek.

When migrated LDAP tree contains 2 groups with identical GID, IPA migration plugin returns incomprehensible error:

# echo "secret123" | ipa migrate-ds ldap://vm-054.idm.lab.bos.redhat.com --with-compat --base-dn=dc=greyoak,dc=com
ipa: ERROR: The search criteria was not specific enough. Expected 1 and found 2.

This is indeed an invalid LDAP on user side, but the error message we provide should be clearer - so that user knows what to fix.

This is the part in the migration plugin that raises the error:

        if entry_attrs['gidnumber'][0] not in valid_gids:
            try:
                (remote_dn, remote_entry) = ds_ldap.find_entry_by_attr(
                    'gidnumber', entry_attrs['gidnumber'][0], 'posixgroup',
                    [''], search_bases['group']
                )
                valid_gids.append(entry_attrs['gidnumber'][0])
            except errors.NotFound:
                api.log.warn('Migrated user\'s GID number %s does not point to a known group.' % entry_attrs['gidnumber'][0])