Description of problem:
During system integration test day for IPA winsync, as part of negative testing
we tried to re-add/modify an existing agreement, this however failed since we
had an existing agreement established. The error message displayed did not
convey any message about existing agreement. Thanks to hbansal for pointing at
this.

Version-Release number of selected component (if applicable):
ipa-server-2.1.3-9.el6.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Create winsync agreement.
2. Try to modify the parameter using "--win-subtree" or re-add the agreement.


Actual results: Though the output says "Failed to create public entry for
winsync replica", it also says "Update succeeded".


Expected results: Should have a better message for error diagnosis.


Additional info:

[root@decepticons ~]# ipa-replica-manage list
decepticons.lab.eng.pnq.redhat.com: master
dhcp201-112.englab.pnq.redhat.com: winsync
[root@decepticons ~]#


[root@decepticons ~]# ipa-replica-manage connect --winsync --passsync=password
--cacert=/root/wincertnew.cer dhcp201-112.englab.pnq.redhat.com --binddn
"cn=Administrator,cn=Users,dc=englab,dc=pnq,dc=redhat,dc=com" --bindpw
Secret123 -v -p Secret123
--win-subtree=ou=testou1,dc=englab,dc=pnq,dc=redhat,dc=com
Added CA certificate /root/wincertnew.cer to certificate database for
decepticons.lab.eng.pnq.redhat.com
INFO:root:AD Suffix is: DC=englab,DC=pnq,DC=redhat,DC=com
The user for the Windows PassSync service is
uid=passsync,cn=sysaccounts,cn=etc,dc=lab,dc=eng,dc=pnq,dc=redhat,dc=com
Windows PassSync entry exists, not resetting password
INFO:root:Added new sync agreement, waiting for it to become ready . . .
INFO:root:Replication Update in progress: FALSE: status: 0 Replica acquired
successfully: Incremental update succeeded: start: 20111121071735Z: end:
20111121071735Z
INFO:root:Agreement is ready, starting replication . . .
INFO:root:Failed to create public entry for winsync replica
Starting replication, please wait until this has completed.
Update succeeded
Connected 'decepticons.lab.eng.pnq.redhat.com' to
'dhcp201-112.englab.pnq.redhat.com'
[root@decepticons ~]#