Ticket #7 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

Draft to review: D

Reported by: limb Owned by: spot
Priority: minor Milestone:
Component: Guideline Draft Version:
Keywords: Cc: bioinfornatics@…
Blocked By: Blocking:

Description

https://fedoraproject.org/wiki/D%2Bpackaging%2Bguideline%2Bdraft

Submitted by Jonathan Mercier, bioinfornatics@…

Change History

comment:1 Changed 4 years ago by spot

A few points:

  • You probably mean "must" rather than "should" in that draft.
  • Please provide definitions for the macros you're using. Also, if those macros come from a specific package, you'll want to also have BuildRequires?: whateverprovidesthosemacros-devel
  • Please include a template spec for people to use as a base or example

comment:2 Changed 4 years ago by limb

  • Cc bioinfornatics@… added

CCing submitter

comment:3 Changed 4 years ago by bioinfornatics

i have updated this draft

comment:4 Changed 4 years ago by spot

I've cleaned up and simplified the draft a bit.

There is one minor issue. How does a normal D package actually use %{d_includedir} in practice? Is it passed to configure? Or are the files moved into the directory manually during %install. It would be nice to reflect that in the template spec.

comment:5 Changed 4 years ago by spot

Jonathan, at today's meeting, the issue of how %{d_optflags} are actually used came up. Do you have a package that actually follows these guidelines that we can look at?

comment:6 Changed 4 years ago by bioinfornatics

you can use %{d_includedir} in build section with a makefile like

make INCLUDEDIR=%{d_includedir}

or in %install for move to %{d_includedir}

%{d_optflags} is used is tango for example

comment:7 Changed 4 years ago by spot

I've cleaned up the draft to resolve the remaining minor issues, this is ready for discussion at the next meeting.

comment:8 Changed 4 years ago by bioinfornatics

great

comment:9 Changed 4 years ago by spot

  • Status changed from new to assigned
  • Owner changed from somebody to spot

This was approved at the 2010-10-13 meeting, 5 +1, no 0, no -1.

comment:10 Changed 3 years ago by spot

  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.