#461 Code Fragments - Bundling or Not for Binwalk
Closed: Fixed None Opened 9 years ago by swt2c.

Hi,

I am working on updating the binwalk[1][2] package. It is mostly a python-based program, but in its most recent version, the authors
have added a little bit of C code. In looking at the C code, I noticed that the authors have taken 2 small files[3][4] from other
projects (ncompress and miniz), modified them, and included them in binwalk.

Would this be considered bundling or not? In searching the archives and FPC tickets, I've seen some discussion about code fragments not
being considered bundling, but I don't see anything in the guidelines.

Thanks,
Scott

[1] https://admin.fedoraproject.org/pkgdb/package/binwalk/
[2] https://github.com/devttys0/binwalk
[3] https://github.com/devttys0/binwalk/blob/master/src/C/compress/compress42.c
[4] https://github.com/devttys0/binwalk/blob/master/src/C/miniz/tinfl.c


We met today and discussed this ticket. We voted to:

  • Permit ncompress fragment bundling
  • Require miniz library package be created and used instead of bundled snippet.

(+1:6, 0:0, -1:0)

It should not be difficult to package the current upstream miniz library as a package (with a copy of the .c files in -devel as headers), then link binwalk to libminiz.

Got it. Thanks for the ruling.

Login to comment on this ticket.

Metadata