This is a 5-line code fragment taken from one file in the 'npm' project, with basically no changes but used in a slightly different context. I've rarely seen attribution for such a small fragment of code, but the author added a copyright header and an extra "Thank you npm".
AFAICT, the original npm project actually only uses the code as part of a unit test so is not shipped to end users. In nodejs-temporary, it is shipped to end users as part of the software itself.
Review Request: https://bugzilla.redhat.com/show_bug.cgi?id=977135
Link to upstream version control: https://github.com/vesln/temporary
Code as seen in the original 'npm' project: https://github.com/isaacs/npm/blob/v1.3.0/test/run.js#L12-17
Code as seen in nodejs-temporary: https://github.com/vesln/temporary/blob/0.0.5/lib/detector.js#L37-44
It's such a small code fragment that I feel a bit silly making this request. Be that as it may, I would like to request a bundling exception for nodejs-temporary.
Yeah, this is kind of below any reasonable threshold for this kind of thing. Nevertheless, we don't actually have a guideline which establishes a lower bound.
+1 if we actually need to vote. I'd hate to hold up a review over this.
+1 and agree with tibbs on all counts.
+1
+1 as well.
That makes (+1:5, 0:0, -1:0). This exception has been approved. As noted in the similar exceptions, we haven't been noting these with Virtual Provides so I'll just close this ticket as fixed.
Thanks again everyone! :-)
Login to comment on this ticket.