Issue #259: Should rpm macro files be marked with any flags (e.g %config and or noreplace)? - packaging-committee

packaging-committee

#259 Should rpm macro files be marked with any flags (e.g %config and or noreplace)?

Closed: Fixed None Opened 11 years ago by dmalcolm.

http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_of_Additional_RPM_Macros talks about macros.$PACKAGE files.

Some packages flag these as %config and/or noreplace, some don't:
{{{
fedora17$ for i in /etc/rpm/*;do printf "%02x %s\n" $(rpm -q --qf "%{fileflags}\n" -f $i) $i;done
11 /etc/rpm/macros.cmake
01 /etc/rpm/macros.color
01 /etc/rpm/macros.dist
11 /etc/rpm/macros.emacs
00 /etc/rpm/macros.fjava
00 /etc/rpm/macros.gconf2
00 /etc/rpm/macros.ghc-srpm
00 /etc/rpm/macros.gnat-srpm
00 /etc/rpm/macros.jpackage
00 /etc/rpm/macros.kde4
00 /etc/rpm/macros.mono-srpm
00 /etc/rpm/macros.ocaml-srpm
00 /etc/rpm/macros.perl
00 /etc/rpm/macros.prelink
11 /etc/rpm/macros.python2
11 /etc/rpm/macros.ruby
51 /etc/rpm/macros.systemd
}}}
...where 0x01 and 0x10 are RPMFILE_CONFIG and _NOREPLACE respectively, see rpm/rpmfi.h.

What flags should such flags have?

[Note to self: https://bugzilla.redhat.com/show_bug.cgi?id=914789 which is about macros.python2 having both flags in internal-to-RH builds of python.el7]

corsepiu commented 11 years ago

IMO, all these files are system config files and are not supposed to be edited/modified by user or admins.

Therefore, I think, these files all should not be marked %config or %config(noreplace).

toshio commented 11 years ago

Approved: RPM Macro files '''MUST NOT''' be marked as %config (+1: 5, 0: 0, -1: 0)

I'll write it up into the Guidelines

toshio commented 11 years ago

Added. Announcement text:

"The packaging guidelines have been clarified to specify that RPM Macro files stored in /etc/rpm/ are not to be marked %config."

dmalcolm commented 11 years ago

Replying to [comment:3 toshio]:

Added. Announcement text:

"The packaging guidelines have been clarified to specify that RPM Macro files stored in /etc/rpm/ are not to be marked %config."

For reference, the relevant edit was:
https://fedoraproject.org/w/index.php?title=Packaging%3AGuidelines&diff=325012&oldid=323210

dmalcolm commented 11 years ago

Flags removed from '''python''' in master (aka f19) in:
http://pkgs.fedoraproject.org/cgit/python.git/commit/?id=6b3f9096ed22808ce42d190a8d87e03560fd8564

Flags removed from '''python3''' in master (aka f19) in:
http://pkgs.fedoraproject.org/cgit/python3.git/commit/?id=19e1adc11eea263c8d8063f44e6c6ce790c345fe

vondruch commented 11 years ago

David, have you considered to move this macros into /usr/lib/rpm/macros.d ? In that place, there is no question about %config. And as Ralf said: "all these files are system config files and are not supposed to be edited/modified by user or admins.", so why they should be in /etc on the first place?