Ticket #252 (closed defect: wontfix)

Opened 3 years ago

Last modified 2 years ago

Simplify github guidelines

Reported by: sochotni Owned by:
Priority: minor Milestone:
Component: Guideline Draft Version:
Keywords: Cc:
Blocked By: Blocking:

Description

About the same time that last github guidelines change happened they actually started producing very nice tarballs with stable checksums.

What we can now use is something similar to this:

https://github.com/jnr/jnr-enxio/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz

This uses two things:

  1. github produces stable URL https://github.com/jnr/jnr-enxio/archive/<tag>.tar.gz
  2. The <tag> is usually not what we want filename to be so we make it nicer and fool rpm and spectool a bit by adding "#/%{name}-%{version}.tar.gz".
  3. This will create a properly named file with %{name}-%{version} as top-level directory

I believe http://fedoraproject.org/wiki/Packaging:SourceURL#Github should be simplified to reflect this

Change History

comment:1 Changed 3 years ago by sochotni

I am working on preparing a modification to current guidelines and this confuses me a bit:

For a number of reasons (immutability, availability, uniqueness), you must use the full commit revision hash when referring to the sources.

Why is this required instead of allowing use of github tags directly? I understand tags can be changed, but same thing is true for uploaded tarballs and there are no special requirements for them.

comment:2 Changed 3 years ago by toshio

https://fedorahosted.org/fpc/ticket/233 has a long discussion of various github provided urls that were tried and discarded. The portion about tags is probably most condensed here: https://fedorahosted.org/fpc/ticket/233#comment:9 There may also have been some discussion about tags vs commit hashes in the meeting logs for that week.

comment:3 Changed 3 years ago by sochotni

Thanks for pointers, I'll try to make sure not to break any of those requirements (and if I can't I'll just abandon this endeavour I guess :-))

comment:4 Changed 2 years ago by limb

Please update this ticket regarding its continued relevance, providing any information requested. If this is not done within the next two weeks, this ticket may be closed due to inactivity. Thank you!

comment:5 Changed 2 years ago by limb

  • Resolution set to wontfix
  • Status changed from new to closed

his ticket is being closed due to inactivity. If the issue referenced has not been resolved, please reopen the ticket and provide the information requested. Thank you!

Note: See TracTickets for help on using tickets.