Ticket #236 (new defect)

Opened 17 months ago

Last modified 16 months ago

ownCloud server - exceptions for bundled libraries

Reported by: brummbq Owned by:
Priority: minor Milestone:
Component: Bundled Library Exception Version:
Keywords: Cc:
Blocked By: Blocking:

Description

Heda,

I'm currently working on ownCloud for Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=858841

In the folder 3rdparty we have 6 bundled libraries left, including 3 php libs and 3 JavaScript? libs.

PHP: smb4php (single php class, newest release, 5 years old) php-when (single php class, latest commit 2 years ago, probably dead) phpass (2 files, project doesn't look too active, latest commit 20 months ago)

it seems pointless to re-package those old and abandoned php classes.

JavaScript?: chosen, fullcalender and timepicker

I hope that I can use the copylib exception for the js-libs. In any way I don't think you are supposed to unbundle them. Note that this is client-only code, they don't run on the server.

Attachments

smb.diff (2.2 KB) - added by brummbq 16 months ago.

Change History

comment:1 Changed 17 months ago by toshio

the php files should be unbundled. being old dosen't have any bearing by itself. (If they also had local modifications it might be a different answer).

Currently javascript libraries that only run on the client are not covered by the policy. this could change in the future but no-one has had the will to finish a draft guideline to cover that.

Changed 16 months ago by brummbq

comment:2 Changed 16 months ago by brummbq

php-when and phpass are unmodified, but smb4php differs quite a lot.

You can see the corresponding commits here: https://github.com/owncloud/3rdparty/commits/247f670a052cad4779ba3dd377756e735af4300d/smb4php/smb.php

comment:3 Changed 16 months ago by brummbq

Do you need additional information?

Note: See TracTickets for help on using tickets.