#210 please change recommendation for Requires(post): systemd-units to Requires(post): systemd in system scriptlets policy
Closed: Fixed None Opened 11 years ago by lennart.

systemd-units does not exist anymore and got replaced by systemd.

The systemd snippets in the guidelines currently suggest this:

{{{
Requires(post): systemd-units
Requires(preun): systemd-units
Requires(postun): systemd-units
}}}

but they should suggest this:

{{{
Requires(post): systemd
Requires(preun): systemd
Requires(postun): systemd
}}}

(Since we provide systemd-units from systemd this is not a huge issue, but deserves to fixed in the guidelines to be less confusing)

In the scriptlets for F17 and older this should not be changed however, as we actually really have the split there still.


Also, there's a typo:

{{{
Some services do not support being restarted (e.g. D-Bus and various storage daemons). If your service should not be restarted upon upgrade, then use the following %post scriptlet instead of the one shown above:
}}}

this should be %postun rather than %post.

EASYFIX, will do it (+1:5, 0:0, -1:0)

Announce text:

The systemd Scriptlets for Fedora 18+ have had their corresponding scriptlet Requires adjusted from "systemd-units" to "systemd", since "systemd-units" is provided by the "systemd" package in Fedora 18+. There is still a separation in previous releases of Fedora (16/17), so packagers can choose to continue using the old Requires (systemd-units) if they are targeting multiple versions of Fedora with a single spec file.

https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Macroized_scriptlets_.28Fedora_18.2B.29

Metadata Update from @spot:
- Issue assigned to spot

7 years ago

Login to comment on this ticket.

Metadata