Ticket #197 (closed: fixed)

Opened 5 years ago

Last modified 4 years ago

Ruby Guidelines inconsitency

Reported by: vondruch Owned by:
Priority: normal Component: Clarification
Keywords: Cc:
Blocked By: Blocking:



It was pointed out that the Ruby Packaging Guidelines are inconsistent a bit. In the example in building gems chapter [1], there is used ./%{_bindir} and ./%{gem_dir} on several places while on the other places there is missing a slash, e.g. there is used .%{_bindir} and .%{gem_dir} respectively.

Would you mind to make the example a bit more consistent and remove the slashes from everywhere, since they are superfluous (and it looks ugly in the logs ;)).

Thank you.

[1] http://fedoraproject.org/wiki/Packaging/Ruby#Building_gems

Change History

comment:1 Changed 5 years ago by toshio

  • Component changed from Guideline Draft to Clarification

+1 for consistency. I think someone specifically asked for "./%{_bindir}" though. I think they thought with ".%{_bindir}" it was too easy to miss the ".". If adding the slash everywhere is okay with you, I'll just fix it as it's just a clarification.

comment:2 Changed 5 years ago by vondruch

Eh, what can I say? :) I already expressed my preferences. Just to put it into context, this issue was pointed out at [1] and it was also about removing the slashes.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=831749#c11

comment:3 Changed 4 years ago by spot

EASYFIX, just do it one way or the other. Don't want to bikeshed here. Toshio, pick one. :)

comment:4 Changed 4 years ago by toshio

  • Status changed from new to closed
  • Resolution set to fixed

Done. The Guidelines now use ./%{DIR} everywhere.

Note: See TracTickets for help on using tickets.