Ticket #183 (closed enhancement: fixed)

Opened 23 months ago

Last modified 23 months ago

recommend using %make_install

Reported by: sundaram Owned by: spot
Priority: minor Milestone:
Component: Guideline Draft Version:
Keywords: Cc:
Blocked By: Blocking:

Description

Details at

https://fedoraproject.org/wiki/Make_install_packaging_draft

It is just a very minor enhancement.

Change History

comment:1 Changed 23 months ago by toshio

Counter proposal: Just enhance this section:

http://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

To mention %{make_install} in addition to make install DESTDIR=%{?_buildroot}. Request rpmdev-newspec to use %{make_install} in the templates it generates.

(I say this because we don't actually currently tell people to use make install DESTDIR[...]... except in the context of telling them not to use %makeinstall.)

If someone could also generate a list of all places in current guidelines that we use make install DESTDIR[...], we could change those to use the macros as well.

comment:2 Changed 23 months ago by sundaram

Either way would work but I think we should avoid introducing double negation in some indirect way but adding a recommendation within a note not to use something. Rewriting that section would make more sense IMO. Updating rpmdev-newspec is a good suggestion. I have filed https://bugzilla.redhat.com/show_bug.cgi?id=828455. Thanks.

comment:3 Changed 23 months ago by corsepiu

As I won't be able to attend this week's FPC meeting, here is my vote: -1

Rationale: I don't see %make_install to provide any advantage over make install DESTDIR=..., esp. when considering that make install DESTDIR=... is well known and understood for many, many years.

That said, to me, all %make_install does, is to add further macro-bloat and incompatibilities to older Fedora releases and to other distros.

I am strongly in favor of intentionally not recommend using %make_install, but to use make install DESTDIR=... everywhere.

comment:5 Changed 23 months ago by spot

  • Owner set to spot

abadger1999's suggestion to amend the language to "Instead, Fedora packages should use: %make_install (Note the "_"!), make DESTDIR=%{buildroot} install or make DESTDIR=$RPM_BUILD_ROOT install. Those all do the same thing." is approved (+1:6, 0:0, -1:1)

comment:6 Changed 23 months ago by toshio

text has been added to the Guidelines.

Announcement text:

Mention that the %make_install macro (*not* to be confused with %makeinstall) may be used instead of "make DESTDIR=%{buildroot}".

comment:7 Changed 23 months ago by spot

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.