#132 Bundled Library Exception: piglit contains constantly modified version of glew
Closed: Invalid None Opened 12 years ago by mcepl.

I am packaging piglit (an OpenGL test suite; http://cgit.freedesktop.org/piglit/) which is constantly upgrading testsuite. We are using piglit for RHEL Xorg QA and I plan to upgrade it constantly (at least couple of times a month from git checkouts). Being developed by the same people who are developing mesa, it contains variously modified and still changing versions of glew.

Given that constant patching of piglit testsuite to use our system library would require an excessive effort, and given it would contribute little to the overall security of the system (piglit tests are usually run in a rather closed environment).

I wouldn't expect that changes be useful to anybody else. If the development of piglit slows down a bit, I could reevaluate and switch to the system library.

More details in the packaging review bug https://bugzilla.redhat.com/show_bug.cgi?id=773021 Reviewer suggested bundling.


Just a question, is piglit really valuable as a GL testing tool when one of the GL libraries it is using/testing doesn't match the system copy?

Yes, because it is not that much testing of this library but rather general GL and drivers implementation.

Yeah from X.org/Mesa point of view this makes most sense, we've often had to patch glew with fixes we find in testing before upstream has done a release.

Bundling request was not approved (+1:1, 0:1, -1:5).

A question was raised around airlied's comment, specifically "If you found bugs in glew, why not patch them globally so that everyone benefits?"

Basically, we would need more rationale to consider this bundling request, and we cannot find enough. Should you wish to plead this case again, you're welcome to offer more rationale.

However, as is, you will need to either use the system glew or not package this item for Fedora.

Oh well, the later. For me it was just a convenience and trying to be community oriented. So, I will continue to use internal repos. I think the only who really lost is the Fedora community.

Login to comment on this ticket.

Metadata