This was approved with the note that FESCo would like some coordination of the porting (since PIL is used in a fair number of packages). I volunteered to help with that.

Looking things over, could we get the Pillow package reviewed and built for python2 in rawhide now so that we can start with porting?

Since there isn't a PIL on python3, there shouldn't be any need to work further on porting when the python3 bug is fixed and the python3 version of pillow enters the repositories.

It looks like we should be able to begin porting even before the pillow package is in. PIL provides both "import Image" and "from PIL import Image".

Another note, the implementation of PIL's "import Image" means that we should be scanning for imports of anything in %{python_sitearch}/PIL/. I'll write a script that can help with that.

I'll attach a run of repoquery --whatrequires 'python-imaging*' on a rawhide box. Note that I get less packages than the Feature page mentions. If you would like to upload your list (or just the additional packages) I can make sure we check what's happening with those additional packages.

results of repoquery --whatrequires 'python-imaging*' on rawhide. This is the list of packages to check
pil-deps.txt

Script to check for all PIL related imports
scan-for-pil.py

scan-for-pil.py​ needs python-sh installed. It will grep all the files in the current directory for modules provided by PIL that also contain an import line. Since it's just grepping, not actually parsing the syntax, it might miss things like multiline imports:

{{{
import os, subprocess, \
Image

or

import (os, subprocess,
Image)
}}}

but it should be pretty accurate otherwise. It will show code that's already been ported to the new syntax {{{from PIL import Image}}} but I figure we want to see those anyway to confirm the package is doing the right thing where it has deps on python-imaging.

Slightly fixed scanner for PIL imports (PIL is shipped in multiple rpm packages)
scan-for-pil.2.py

I'm happy to post a pillow python2 package review immediately if that's helpful (I take adding the python3 variant would require a re-review?). Maybe it would also be helpful to raise attention on the python3 bug on fedora-devel in the meantime?

python3 is going to be a subpackage of the python-pillow package corrrect? If so, a re-review shouldn't be necessary. But I can certainly look at what you do to implement it if you want a second pair of eyes. (It is kinda a flaw in our package review process that major changes don't require a review but we lack the manpower to do that in a timely fashion for everything.)

For the python3 bug, yep it may be. I'll also see about ambushing{{{^W}}}pinging dmalcolm about the bug.

Yes, it is a subpackage. I'd say I'll wait for a week or so to see if things move on the python3 front, otherwise I'll post the python2-only package for review?

Since the current python-imaging supports the new format for the import as well as the old porting can take place using python-imaging; python-pillow doesn't need to be in place beforehand. So yeah, sounds fine to me to see if the python3 bug can be fixed before the pillow package is reviewed.

sgallagh and I have finished auditing and adding patches for the python packages that required python-imaging. Feature page updated with the information. Tracker bug lists all the packages that need to have our patches applied: https://bugzilla.redhat.com/showdependencytree.cgi?id=894484&hide_resolved=1 At some point later in the cycle we should probably see which packages haven't had the patches applied and have provenpackagers fix them. (I can do some of that too -- just prefer to let the maintainers have a chance to look first. Especially since the maintainers can get the patches into upstream.)

If you know of any other packages that need to be checked, feel free to ping me for more help.

Many thanks. I've pinged the python3 bug yesterday in the hope of getting some hint when we might expect a fix. Actually, the proposed fix seems rather safe to apply afaics, since it only affects distutils, which is completely broken atm, so probably no-one is using distutils with the search_library function with python3. The patch should only improve the situation.

What's the status? Is it fixed?

python3 bug is not fixed. Review request for python-pillow has been submitted without the python3 subpackage. All but two packages have had pyxml dep removed and those two are just waiting on an upstream release.

Feature is not blocked by exterior forces at this time but fesco might want to ping about the python3 bug and see if dmalcolm (python3 maintainer) is in need of help/comaintainer/etc. Having Pillow available for python3 would be noteworthy for users whereas replacing python-imaging with python-pillow for python2 is just an internal cleanup.

Python3 bug report: https://bugzilla.redhat.com/show_bug.cgi?id=889784

Python-pillow review request: https://bugzilla.redhat.com/show_bug.cgi?id=908114

Seems like this ticket could be closed, Feature is now marked as 100% done, Python 3 issue should be fixed now - thanks Toshio.

Thanks for the reminder.