Ticket #280 (closed task: fixed)

Opened 4 years ago

Last modified 4 years ago

Compose of fixed LXDE spin images

Reported by: cwickert Owned by:
Priority: major Keywords: meeting
Cc: spot Blocked By:
Blocking:

Description

Proposal topic

After the LXDE spin was withdrawn due to a serious error, we now need to compose new images.

Overview

The problems were fixed 2 days later. For the new images we need

Problem space

From what repos do we compose the new images?

Solution Overview

  1. From 'Everything' plus everything from 'updates'
  2. From 'Everything' and only take menu-cache-0.2.6 from 'updates'
  3. Take some selected packages from 'updates' e.g latest PackageKit?

As the spin owner I prefer solution 2.

Active Ingredients

rel-eng, websites

Owners

cwickert

Change History

comment:1 Changed 4 years ago by kevin

I think #2 is best. However, we need to make sure we have that exact src.rpm also available. Perhaps we could just stick it in the same directory as the spin with an extra note in the readme thats where it's available from?

comment:2 Changed 4 years ago by jstanley

I think that option 2 is likely the best here, +1 to that.

Can other FESCo members please vote such that we can get this off the ground quickly, being that the meeting today was cancelled and the meeting next week is also cancelled.

Thanks!

comment:3 follow-up: ↓ 5 Changed 4 years ago by dwmw2

I agree. Option #2 is the sanest.

I understand that a new lxde-settings-daemon package is currently being tested, which should really fix the problem instead of working around it? That would obviously be a nice thing to have too...

comment:4 Changed 4 years ago by kkofler

Given that:

  • option 2 is the least risky,
  • it is the least surprising (users probably expect the images to reflect the release as closely as possible) and
  • it is the preference of the spin owner

I vote another +1 to option 2.

Of course it's somehow suboptimal not to include all the updates, but they are a moving target anyway, so pulling in the minimum changes to make the spin work (i.e. option 2) sounds like the better plan (as compared to 1). As for option 3, it is well-meaning, but it's hard to decide which updates to include ("Why this update and not this other one?") and it leads to an untested combination (we can't test all possible combinations of selective updates).

comment:5 in reply to: ↑ 3 Changed 4 years ago by cwickert

Replying to dwmw2:

I understand that a new lxde-settings-daemon package is currently being tested, which should really fix the problem instead of working around it?

lxde-settings-daemon 0.4.1 does not fix the problem, so no need to wait for another update. The requirements are still the same as described at the beginning of this ticket.

comment:6 Changed 4 years ago by cwickert

Ping? I really need a decision and new images ASAP. Thanks.

comment:7 Changed 4 years ago by notting

  • Cc spot added

I'll vote for option #2, *provided* that the source RPM is included in the torrent as well. Spot, would that cover our requirements?

comment:8 Changed 4 years ago by sharkcz

+1 for option 2

comment:9 Changed 4 years ago by skvidal

+1 to option2 with the caveat mentioned by notting.

comment:10 Changed 4 years ago by jwilson

option 2 is fine by me

+1 for numero dos.

comment:11 Changed 4 years ago by notting

It was noted that the update to menu-cache is an unrelated security update; it is *not* required to fix the crash on login. Does that change people's opinions?

(It makes me more likely to suggest just respinning with the kickstart fix.)

comment:12 Changed 4 years ago by skvidal

yes, if we don't need the new pkg then we respin it with just the kickstart fix.

comment:13 Changed 4 years ago by kkofler

Are you sure it's not needed? cwickert?

comment:14 Changed 4 years ago by cwickert

Yes I am, please read the discussion in bodhi I linked in the initial comment.

comment:15 Changed 4 years ago by kevin

my vote then is: spin with just the ks change. No updated packages.

comment:16 Changed 4 years ago by cwickert

Dear FESCO members, what do you think now?

The menu-cache update is not absolutely necessary for the spin, but I wanted to have it in because according to upstream it's a security update and I didn't want to ship a spin with a potential vulnerability. I doubt it actually is a security problem (as outlined in the update I linked) and we also ship the old PackageKit?, so this is not much different. I should have been more clear about this, sorry, but for me it was obvious from the links.

Please vote about shipping the spin with just the fix to the ks. And please vote ASAP because there are people waiting for that spin. So far we have the votes of kevin and skvidal.

comment:17 Changed 4 years ago by kkofler

+1 for respinning with only the kickstart fix.

comment:18 Changed 4 years ago by sharkcz

+1 to the respin with the ks fix only

comment:19 Changed 4 years ago by notting

+1 to respin with ks fix only.

comment:20 Changed 4 years ago by ausil

+1 for respining with only a ks change. this ensures we dont need to do any tricks for the changed packages SRPM since we point people to the Everything release source tree for spins.

comment:21 Changed 4 years ago by jwilson

+1 for whatever everyone else decides on. I really don't care. Not even sure why we're being asked how a spin has to be made, to be honest. I think the maintainer of the spin should do what they feel delivers the best spin.

comment:22 Changed 4 years ago by cwickert

  • Resolution set to fixed
  • Status changed from new to closed

Images are online now. Thanks everybody and especially Jesse for composing them.

Note: See TracTickets for help on using tickets.