Replying to [ticket:1069 jreznik]:

Feature owners - please answer the question from devel-list:
"Is this actually useful if anaconda doesn't set up the system to use the
thinp pool to begin with? (Because it doesn't.)"

Yes, system rollback will still be possible if a user converts a regular LV over to being an "external origin" that is backed by a specified thin-pool. At that point snapshots may be taken of the "external origin". Therefore it is still useful to get the yum fs-snapshot plugin enhanced to be thinp-aware even if anaconda doesn't setup the system to use thinp.

But given that anaconda sets up the entire storage pool as specific LVs, where would the thin-pool come from?

Replying to [comment:2 notting]:

But given that anaconda sets up the entire storage pool as specific LVs, where would the thin-pool come from?

The user does have the freedom to customize how much space the system LVs consume. Space could easily be left free for use by a thin-pool that would be created after the initial installation.

I'm not saying this is likely to be a heavily used feature but there is no reason we need to hold back wider system support for thinp just because anaconda cannot put time to adding thinp support to the installer.

What I'd suggest is that it's probably worth more to try and get thinp support into the installer first to have this working out of the box - I don't like the idea of just doing a quick change in yum-fs-snapshot and losing sight of the full integrated package that would make a really awesome Feature.

Replying to [comment:4 notting]:

What I'd suggest is that it's probably worth more to try and get thinp support into the installer first to have this working out of the box - I don't like the idea of just doing a quick change in yum-fs-snapshot and losing sight of the full integrated package that would make a really awesome Feature.

The thinp work in the yum fs-snapshot plugin needs to be done regardless of when anaconda can put time to thinp support. The developers working on enhancing the yum fs-snapshot plugin are independent of the anaconda team. We're working to make thinp succeed by taking care of tasks that need doing independent of the anaconda changes. The suggestion that by implementing independent changes we're going to somehow lose sight of the installer needing to support thinp is just odd.

So I don't understand your point. Frankly, this is getting tedious. We'll make the yum fs-snapshot changes regardless of whether Fedora cares to formally accept them for Fedora 19. I'm sure the upstream yum-utils developers will take our changes when they are ready.

I was asking just because I'd find thinp support in anaconda much more useful.

In any case, can the Documentation section, when it's done, describe how to set up the thin pool (and how to ensure that anaconda doesn't use the full space so it's available?)

AGREED: Feature is approved (+9, 0, 0)